-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: Clarify / make consistent naming steps for HTML form controls #2395
Open
scottaohara
wants to merge
3
commits into
main
Choose a base branch
from
form-control-naming-updates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updates the listed inputs and button types to steps more consistent in wording. - incorporates w3c/accname#246 into the label steps for the mentioned form controls - starting to migrate from just using "subtree" to "text equivalent computation of the element's subtree" - as the simple use of 'subtree' has come up in a handful of reviews for html aam naming steps the "other form controls" is not touched in this update - as there are also other pending PRs - re select element - that start breaking that apart.
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
scottaohara
added a commit
that referenced
this pull request
Dec 11, 2024
keeping in alignment with wording updates in #2395
spectranaut
changed the title
Clarify / make consistent naming steps for HTML form controls
Editorial: Clarify / make consistent naming steps for HTML form controls
Dec 12, 2024
accdc
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks. :)
hidde-logius
approved these changes
Dec 13, 2024
Co-authored-by: Hidde de Vries <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should not contain any normative changes
the "other form controls" is not touched in this update - as there are also other pending PRs - re select element - that start breaking that apart.